Fix pie chart data lables #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-trivial and will require more work
…il plot. Also add check to ensure pie charts with less than or equal slices to the label limit will have all of its labels shown (possibly truncated if too long and is a not a default sized plot).
…rdless of the number of labels
3 tasks
…h many tiny pie slices will cause the data labels to stack, rendering the pie chart unreadable
jpwhite4
reviewed
Jan 2, 2025
| if ($isThumbnail || ($labelsAllocated < $labelLimit && (($yValues[$i] / $pieSum) * 100) >= 2.0)) { | ||
| $label = $xValues[$i]; | ||
| // Truncate long data labels to improve visibility. | ||
| if (strlen($xValues[$i]) >= 70) { |
There was a problem hiding this comment.
Suggested change
| if (strlen($xValues[$i]) >= 70) { | |
| if (mb_strlen($label) >= 70) { |
There was a problem hiding this comment.
Also why only keep 40 characters but have the threshold set to 70 bytes?
There was a problem hiding this comment.
if 69 characters fits then why not have:
if (mb_strlen($label) >= LABLE_TRUNCATE_LEN) {
$label = mb_substr($label, 0, LABLE_TRUNCATE_LEN - 3) . '...';
}
where LABLE_TRUNCATE_LEN would be set to something sensible (presumably between 40 and 70).
There was a problem hiding this comment.
I'm not sure why I had those set so differently. Should be addressed now.
jpwhite4
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk: LOW
Severity: MEDIUM (heavily affects readability of some pie charts)
Description
These changes fix the pie chart margin for when very long data labels are showing.
Also discovered that pie chart margin for some of the interactive charts have clipping with the data labels. This fix is non-trivial and will require some more effort in a separate PR. This is because the margin for pie charts may need to be re-worked entirely due to interactions with the subtitle, and different legend locations.
Motivation and Context
Pie charts with long data labels were barely visible
Tests performed
Tested on xdmod-dev
Checklist: